lib: find extensive Win10SDK installation#2259
Open
mcdmaster wants to merge 7 commits intonodejs:mainfrom
Open
lib: find extensive Win10SDK installation#2259mcdmaster wants to merge 7 commits intonodejs:mainfrom
mcdmaster wants to merge 7 commits intonodejs:mainfrom
Conversation
This isn't needed, and was probably copy-pasted from windows-build-tools' README.md, which has since been changed to drop the `--production` flag from the install instructions. Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Matias Lopez <imatlopez@gmail.com> PR-URL: nodejs#2210 Closes: nodejs#2127 Closes: nodejs#2209
PR-URL: nodejs#2218 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Matias Lopez <imatlopez@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May close #2234
Checklist
npm install && npm testpassesDescription of change
Added facility to detect extensive installations of Windows 10 SDK. In previous version, only SDK version which comes out of the VS Installer menu list were accepted, because it can go to MS VS Workload like:
Microsoft.VisualStudio.Component.Windows10SDK.18362.Contrarily, post-installation SDKs, preferred by early-adopting developers, have not been detected in command inputs like
node-gyp configure. This circumstance has slowed down the progress of entire development activities usingNodecomponents.